By Supun Wanniarachchi on 2017-07-21 10:56 in GSoC 17 JS tests for Joomla 4

Thursday, 20 th July 2017 on Glip

Time: 10.00p.m (Colombo Sri Lanka), 6:30 p.m (Munich Germany)

Report: Supun

Previous meeting report

 

List of Attendees Overview

 

Mentor

 

A

Student

 

A

Ruchiranga Wickramsinghe

RW

 

Supun Wanniarachchi

SW

x

Ashan Fernando

AF

X

     

Dimitris Grammatiko

DG

X

     

Yves Hoppe

YH

       

Tobias Zulauf

TZ

       

David Neukirchen

DN

       

 

Topics

1. Update on the work done during the previous week

PRs sent:

https://github.com/joomla-projects/gsoc17_js_tests/pull/26

https://github.com/joomla-projects/gsoc17_js_tests/pull/25

https://github.com/joomla-projects/gsoc17_js_tests/pull/24

https://github.com/joomla-projects/gsoc17_js_tests/pull/23

 

Supun sent some PRs and mentioned below issues.

 

Frontediting - https://github.com/Supun94/gsoc17_js_tests/blob/ace8df0b8571b3547386af4ab7f0438a391d852e/media/system/js/frontediting.js#L118

 

https://github.com/Supun94/gsoc17_js_tests/blob/ace8df0b8571b3547386af4ab7f0438a391d852e/media/system/js/frontediting.js#L182

Dimitris mentioned issues in frontediting should be ignored at the moment, as the tooltip and popover are jQuery dependent till we get the web components for those components.  



 

2. Test Vanilla script

 

Script

Testing Instruction

1. treeselectmenu

Administrator, module edit view, menu assignment

2. tabstate(with new changes)

Administrator Article edit

3. frontendediting

Front End, article edit (needs to be set in the Joomla configuration)

4. permissions



Administrator Article edit, last tab

5. mediafield

Administrator Article edit, images tab

6. fielduser  

Administrator Article edit, publication tab

7. subform  

 

 

There are some scripts we cannot remove jQuery as it's used elsewhere. eg mediafield and fielduser both need jQuery + bootstrap for the modal. This PR https://github.com/joomla/joomla-cms/pull/17024   sent by Dimitris, then all these jQuery scripts will be removed from code (tooltips, popover, modals, tabs, dropdown etc) and this will merge soon.

 

4. Other Unit testing component

Planned to add Unit testing for VanillaJS converted libraries during the next week.

5. Tasks for next week

  1. Test the VanillaJS PRs and do the necessary changes.

  2. Start Unit Test coverage for new javascript library.

  3. Looking at the issue and send the fix https://github.com/jshjohnson/Choices/issues/163 sent by Dimitris